Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs as Quarkus no longer defautling keystore type to JKS #39232

Merged

Conversation

jedla97
Copy link
Contributor

@jedla97 jedla97 commented Mar 6, 2024

As explained in #39151 the keystore no longer defaulting to any type. Mention in migration guide https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.9#keystore-and-trust-store-default-format-chang. So we should change it in docs as well.

@cescoffier if you disagree and I understand it wrongly feel to close this.

Copy link

quarkus-bot bot commented Mar 6, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit fbea7a4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

github-actions bot commented Mar 6, 2024

🙈 The PR is closed and the preview is expired.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks!

@cescoffier cescoffier merged commit 32e3ebb into quarkusio:main Mar 6, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants