Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets Next: rename WebSocketServerConnection to WebSocketConnection #39193

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Mar 5, 2024

@mkouba mkouba requested review from cescoffier and geoand March 5, 2024 15:58
Copy link

quarkus-bot bot commented Mar 5, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 3bab424.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/websockets-next/server/deployment

io.quarkus.websockets.next.test.broadcast.BroadcastOnMessageTest.testUpMultiBidi - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.websockets.next.test.broadcast.BroadcastOnMessageTest.assertBroadcast(BroadcastOnMessageTest.java:96)

@mkouba mkouba merged commit 2eae41e into quarkusio:main Mar 5, 2024
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 5, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSockets Next: rename WebSocketServerConnection to WebSocketConnection
3 participants