Increase JNI metrics values to account for (upcoming) 17.0.11+1 changes #39056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDK-8316304 got backported to JDK 17.0.11+1, therefore adding two fields accessed by JNI.
quarkus-bot
bot
added
area/hibernate-orm
yrodiere
approved these changes
Feb 28, 2024
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mandrel
23.0.4will be JDK17.0.11based (April CPU). JDK-8316304 got backported to JDK 17.0.11+1, therefore adding two fields accessed by JNI. The tolerance should be large enough for it to work with a JDK 17.0.10-based build too (70*0.97 = 67.9).See the test failure for example here:
https://github.com/graalvm/mandrel/actions/runs/8068592571/job/22043086080?pr=683#step:12:497
/cc @zakkak