Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to warn about failures when loading workspace modules, instead of throwing errors #38937

Merged

Conversation

aloubyansky
Copy link
Member

This option is added to support use-cases beyond Quarkus application development.

@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Feb 21, 2024

This comment has been minimized.

Partially verified

This commit is signed with the committer’s verified signature.
gsmet’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
… of throwing errors

Co-authored-by: George Gastaldi <[email protected]>
@aloubyansky aloubyansky force-pushed the warn-on-failing-workspace-modules branch from 2fbf6d8 to 23d1d10 Compare February 28, 2024 13:31
@aloubyansky
Copy link
Member Author

@gastaldi applied your suggestions, thanks!

This comment has been minimized.

Copy link

quarkus-bot bot commented Feb 28, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 23d1d10.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

@gastaldi gastaldi merged commit 740b3cb into quarkusio:main Feb 28, 2024
50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants