-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new Vert.x gRPC server for code.quarkus.io #38863
Conversation
Status for workflow
|
I don't know. If we think this is the best approach, shouldn't we switch the default instead? |
We are planning to switch the default. Actually, I think we should now. We were waiting after the LTS. |
Yeah my point is that if you make it the default in generated projects, you might as well switch the default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Well, I wasn't able to backport this because things are failing in 3.7. When testing HelloGrpcServiceTest
|
Actually, this is failing in |
@alesj it seems to be related to the codestart itself? Could you try to build it on both Maven and Gradle? It's yesterday command + |
Hmmm, works for me locally, also with Gradle ...
90% ?! application.properties looks OK ...
|
Test(s) also pass ...
|
This should fix #37608