ArC: improve validation of interceptor method signatures

[Ladicek]

No description provided.

[Ladicek]

I think we might wanna backport this to 3.7/3.8, WDYT @mkouba?

[manovotn]

Looks good but shouldn't we also add a test for @AroundInvoke having void return type?

[Ladicek]

Ah I intended to do that, but forgot! Thanks, will add.

[Ladicek]

Done. Thanks for reminding me!

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7feb424.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

• Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

[gsmet]

I'm not sure about backporting this one? My understanding is that apps that were somehow building without errors will fail, right? Granted, they wouldn't work well but still.
I think we are a bit late in this cycle to do that.

Unless I misunderstood something?
(I could be convinced if you have a case)

[Ladicek]

Not a huge deal if we don't backport this, we already had a mostly good (say 95%) validation in place, this just tightens it up (to 100%).

[mkouba]

@gsmet I agree with Ladislav. So let's not backport this one.