Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler: inheritance of metadata #38791

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Scheduler: inheritance of metadata #38791

merged 1 commit into from
Feb 15, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 15, 2024 •
edited by geoand
Loading

  • turn the warning in the docs into a subsection
  • mention the inheritance rules in the javadoc of the Scheduled annotation
  • fail the build if an abstract class/interface declares a method annotated with Scheduled
  • add support for static interface scheduled methods (so far only static methods declared on a class were supported)

@mkouba
Scheduler: inheritance of metadata
b8b1589 
- turn the warning in the docs into a subsection
- mention the inheritance rules in the javadoc of the Scheduled
annotation
- fail the build if an abstract class/interface declares a method
annotated with Scheduled
- add support for static interface scheduled methods (so far only
static methods declared on a class were supported)
- fixes quarkusio#38781
@mkouba
Copy link
Contributor Author

mkouba commented Feb 15, 2024

CC @edeandrea

@mkouba mkouba requested review from gsmet and machi1990 February 15, 2024 09:27
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 15, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b8b1589.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other check runs running, make sure you don't need to wait for their status before merging.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 15, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 15, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b8b1589.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit 3782467 into quarkusio:main Feb 15, 2024
33 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@machi1990 machi1990 Awaiting requested review from machi1990

Assignees
No one assigned
Labels
area/documentation area/scheduler kind/bugfix
Projects
Quarkus Documentation
Status: Done
Milestone
3.9.0.CR1
Development

Successfully merging this pull request may close these issues.

@Scheduled not found when in parent classes
2 participants
@mkouba @gsmet