-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker exec instead of docker cp to create run script for Kafka native DevService #38790
Conversation
@xstefank that string format is hard to follow, but it looks good! Can we do the same for the redpanda container? |
@xstefank also, the change itself doesn't require the kafka-native release right? We can cut it after? Also you can test with the kafka-native |
This comment has been minimized.
This comment has been minimized.
@ozangunalp redpanda has itself similar issue as we fixed in your kafka-native container (permissions for random UID) so until they fix it in their container, we can't do anything on our side. Add release, yes, this is just a different way to create run.sh script in container so it shouldn't matter. But I see test failures so probably it does? |
|
// docker exec since docker cp doesn't work with kubedock yet | ||
try { | ||
execInContainer("sh", "-c", | ||
String.format("echo -e \"%s\" >> %s && chmod 777 %s", cmd, STARTER_SCRIPT, STARTER_SCRIPT)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following might be a little less confusing (untested):
String.format("echo -e \"%s\" >> %s && chmod 777 %s", cmd, STARTER_SCRIPT, STARTER_SCRIPT)); | |
String.format("echo -e \"%1$s\" >> %2$s && chmod 777 %2$s", cmd, STARTER_SCRIPT)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
51162c6
to
079b2b7
Compare
Status for workflow
|
This also requires ozangunalp/kafka-native#144 to be pushed to quay.io. cc/ @ozangunalp
With this change I was able to successfully run Kafka native DevService in DevSpaces/Che!
config
This would really help us to get the Quarkus super-heroes workshop to be doable in DevSpaces (fully online).
cc/ also @danieloh30 since I heard that this was a blocker for you.