Enable Develocity build cache by default and document it better #38758

gsmet · 2024-02-13T12:58:37Z

No description provided.

maxandersen · 2024-02-13T13:41:28Z

CONTRIBUTING.md


-If you have a need or interest to report build times, you will need to get an API key for the GE instance. It is mainly relevant for those working on optimizing the Quarkus build. Ping on quarkus-dev mailing list or on Zulip if you need one.
+If you have a need or interest to share your build scans and use the build cache, you will need to get an account for the Develocity instance.
+It is only relevant for members of the Quarkus team and you should contact either Max Andersen or Guillaume Smet to set up your account.


any contributor can get it so no real need to put request in private is there?

maxandersen · 2024-02-13T13:42:36Z

.mvn/gradle-enterprise.xml

@@ -26,7 +26,7 @@
    </buildScan>
    <buildCache>
        <local>
-            <enabled>#{env['GRADLE_LOCAL_BUILD_CACHE'] != null and env['RELEASE_GITHUB_TOKEN'] == null and properties['no-build-cache'] == null}</enabled>
+            <enabled>#{env['RELEASE_GITHUB_TOKEN'] == null and properties['no-build-cache'] == null}</enabled>


shouldn't this not only be enabled if access key available?

Ah ah funnily enough, I thought about that during the meeting and already pushed something related.

This is the local cache so we don't care but I added the check for the remote cache just below though (but my understanding is that it's handled anyway).

Only the compile goal is problematic for extensions.

And update it before releasing. This is important for the build cache as we are generating checksums of zips which are dependent on the timestamp.

quarkus-bot · 2024-02-25T17:25:08Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 248a75b.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✖	Native Tests - Data5	`Build`	Failures	Logs	Raw logs	🚧

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Data5 #

- Failing: integration-tests/jpa-postgresql-withxml

📦 integration-tests/jpa-postgresql-withxml

✖ io.quarkus.it.jpa.postgresql.ImageMetricsITCase.verifyImageMetrics line 15 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: Expected analysis_results.fields.reflection to be within range [163 +- 3%] but was 168 ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
	at io.quarkus.test.junit.nativeimage.NativeBuildOutputExtension.assertValueWithinRange(NativeBuildOutputExtension.java:90)
	at io.quarkus.test.junit.nativeimage.NativeBuildOutputExtension.lambda$verifyImageMetrics$0(NativeBuildOutputExtension.java:66)

gsmet force-pushed the enable-build-cache branch from 1e0ed14 to c7715fd Compare February 13, 2024 13:15

maxandersen reviewed Feb 13, 2024

View reviewed changes