-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend scan for CustomResources to full index, instead of simply application index #38586
Conversation
import org.jboss.jandex.ClassInfo; | ||
import org.jboss.jandex.DotName; | ||
import org.jboss.jandex.Type; | ||
import org.jboss.jandex.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid star imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaken, that's the work of the formatter, I didn't do that explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that's the work of your IDE, most probably.
Our formatter shouldn't be adding star imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, my IDE was not properly configured… Thought that running mvn -Dquickly
was formatting the code as well.
This comment has been minimized.
This comment has been minimized.
aab4cc5
to
1cd7a0b
Compare
Status for workflow
|
Would be nice to backport this to 3.7 if possible, btw. |
Is it really needed? We are trying to stabilize 3.7/3.8 as much as possible |
I guess I could add workaround for this in QOSDK until it's available in Quarkus. |
If it's important and / or causes a lot work to workaround, we can have it. We are just trying to be as conservative as possible at the moment. |
No description provided.