Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend scan for CustomResources to full index, instead of simply application index #38586

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

metacosm
Copy link
Contributor

@metacosm metacosm commented Feb 5, 2024

No description provided.

import org.jboss.jandex.ClassInfo;
import org.jboss.jandex.DotName;
import org.jboss.jandex.Type;
import org.jboss.jandex.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid star imports

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, that's the work of the formatter, I didn't do that explicitly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that's the work of your IDE, most probably.

Our formatter shouldn't be adding star imports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, my IDE was not properly configured… Thought that running mvn -Dquickly was formatting the code as well.

This comment has been minimized.

Copy link

quarkus-bot bot commented Feb 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1cd7a0b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit a8d4f9c into quarkusio:main Feb 7, 2024
21 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Feb 7, 2024
@metacosm metacosm deleted the register-crs branch February 7, 2024 14:47
@metacosm
Copy link
Contributor Author

metacosm commented Feb 7, 2024

Would be nice to backport this to 3.7 if possible, btw.

@geoand
Copy link
Contributor

geoand commented Feb 7, 2024

Is it really needed? We are trying to stabilize 3.7/3.8 as much as possible

@metacosm
Copy link
Contributor Author

metacosm commented Feb 7, 2024

I guess I could add workaround for this in QOSDK until it's available in Quarkus.

@geoand
Copy link
Contributor

geoand commented Feb 7, 2024

If it's important and / or causes a lot work to workaround, we can have it. We are just trying to be as conservative as possible at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants