QuarkusComponentTest: support test method parameter injection #38379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Jan 24, 2024
mkouba
commented
- params annotated with SkipInject are never injected
mkouba
force-pushed
the
component-test-method-param-inject
branch
from
3823a0f to
40b7514
Compare
mkouba
force-pushed
the
component-test-method-param-inject
branch
from
40b7514 to
8507b22
Compare
|
@manovotn I know that you have some experience with test method param injection from |
Ladicek
reviewed
Jan 25, 2024
test-framework/common/src/main/java/io/quarkus/test/InjectMock.java
Outdated
Show resolved
Hide resolved
Ladicek
reviewed
Jan 25, 2024
|
🙈 The PR is closed and the preview is expired. |
Ladicek
approved these changes
Jan 25, 2024
mkouba
force-pushed
the
component-test-method-param-inject
branch
from
1cf5af6 to
85bd285
Compare
manovotn
reviewed
Jan 25, 2024
...it5-component/src/main/java/io/quarkus/test/component/QuarkusComponentTestConfiguration.java
Outdated
Show resolved
Hide resolved
test-framework/junit5-component/src/main/java/io/quarkus/test/component/SkipInject.java
Outdated
Show resolved
Hide resolved
.../junit5-component/src/main/java/io/quarkus/test/component/QuarkusComponentTestExtension.java
Outdated
Show resolved
Hide resolved
mkouba
force-pushed
the
component-test-method-param-inject
branch
from
85bd285 to
3cc46ef
Compare
This comment has been minimized.
This comment has been minimized.
Ladicek
reviewed
Jan 26, 2024
...it5-component/src/main/java/io/quarkus/test/component/QuarkusComponentTestConfiguration.java
Outdated
Show resolved
Hide resolved
Ladicek
reviewed
Jan 26, 2024
.../junit5-component/src/main/java/io/quarkus/test/component/QuarkusComponentTestExtension.java
Outdated
Show resolved
Hide resolved
Ladicek
reviewed
Jan 26, 2024
.../junit5-component/src/main/java/io/quarkus/test/component/QuarkusComponentTestExtension.java
Outdated
Show resolved
Hide resolved
|
LGTM otherwise. |
- params annotated with SkipInject are never injected Co-authored-by: Ladislav Thon <[email protected]>
mkouba
force-pushed
the
component-test-method-param-inject
branch
from
3cc46ef to
f853e4c
Compare
mkouba
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. You can consult the Develocity build scans. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.