Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Remove config overriding the parent config #38262

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jan 17, 2024

This makes 3.2 consistent with 3.6+ and will enable autodeploy after close, which wasn't working because of this.

The config is already in the parent, this PR is about not overriding it.
This is not mandatory but will simplify the release process for 3.2 and make it consistent with the more recent versions, which is IMO very much needed to avoid having different processes when releasing everything in a row.

/cc @aloubyansky @rsvoboda

This makes 3.2 consistent with 3.6+ and will enable autodeploy after
close, which wasn't working because of this.
Copy link

quarkus-bot bot commented Jan 17, 2024

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@gsmet gsmet requested review from aloubyansky and rsvoboda January 17, 2024 18:17
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/platform Issues related to definition and interaction with Quarkus Platform area/spring Issues relating to the Spring integration labels Jan 17, 2024
@gsmet gsmet added this to the 3.2.10.Final milestone Jan 17, 2024
Copy link

quarkus-bot bot commented Jan 17, 2024

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@aloubyansky aloubyansky merged commit 0a3c72e into quarkusio:3.2 Jan 18, 2024
44 checks passed
gsmet added a commit to gsmet/conversational-release-action that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/platform Issues related to definition and interaction with Quarkus Platform area/spring Issues relating to the Spring integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants