AWS Lambda Rest: split the amazon-lambda-rest integration module #38213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- into amazon-lambda-rest-resteasy-reactive, amazon-lambda-rest-reactive-routes, amazon-lambda-rest-funqy and amazon-lambda-rest-servlet - to avoid errors/conflicts among HTTP frameworks - there was a regression in the tests caused by e2ae818 during upgrade to Vert.x 4.5.1
quarkus-bot
bot
added
area/amazon-lambda
area/documentation
area/infra-automation
mkouba
commented
Jan 16, 2024
| "timeout": 50, | ||
| "test-modules": "amazon-lambda, amazon-lambda-http", | ||
| "timeout": 80, | ||
| "test-modules": "amazon-lambda, amazon-lambda-http, amazon-lambda-rest-funqy, amazon-lambda-rest-servlet, amazon-lambda-rest-reactive-routes, amazon-lambda-rest-resteasy-reactive", |
There was a problem hiding this comment.
I'm not so sure about this one but I see no reason why it's not run in CI.
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
cescoffier
approved these changes
Jan 16, 2024
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. You can consult the Develocity build scans. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amazon-lambda-rest-resteasy-reactive,amazon-lambda-rest-reactive-routes,amazon-lambda-rest-funqyandamazon-lambda-rest-servlete2ae818 during upgrade to Vert.x 4.5.1