Make sure quarkus.http.filter headers don't remove existing headers
#38185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sberyozkin
reviewed
Jan 15, 2024
...tp/runtime/src/main/java/io/quarkus/vertx/http/runtime/options/HttpServerCommonHandlers.java
Outdated
Show resolved
Hide resolved
cescoffier
requested changes
Jan 15, 2024
The previous behavior would completely replace existing response headers Fixes: quarkusio#38155
|
PR updated with an improved test showing all cases. It will no longer duplicate values |
geoand
changed the title
quarkus.http.filter headers don't remove existing headers
cescoffier
approved these changes
Jan 15, 2024
gastaldi
reviewed
Jan 15, 2024
Comment on lines
+164
to
+165
| } else { | ||
| // we don't need to do anything here as the value was already in the set |
There was a problem hiding this comment.
Remove the unnecessary else block then?
Suggested change
| } else { | |
| // we don't need to do anything here as the value was already in the set | |
| } else { | |
| // we don't need to do anything here as the value was already in the set |
There was a problem hiding this comment.
I wanted to keep it because of the comment
There was a problem hiding this comment.
I see, but it seems to be explicit in your code already and the IDE nags about empty else blocks 😜
There was a problem hiding this comment.
I generally disable that inspection 😉
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. You can consult the Develocity build scans. |
|
@gsmet it might make sense to backport this? |
|
It's a breaking change, so best not to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior would completely replace
existing response headers
Fixes: #38155