New Route SPI not requiring Vert.x HTTP

[cescoffier]

Unlike the current one, this SPI allows declaring routes without having
to depend on Quarkus Vert.x HTTP. Thus, if an extension declares a route
with this SPI if Quarkus Vert.x HTTP is not present, then the route is ignored.
However, if Quarkus Vert.x HTTP is present, then the route is registered.

I changed the info and openapi extensions to verify that the new SPI is correctly handled.

\CC @yrodiere

Fix #37144.

[yrodiere]

Thanks @cescoffier!

@marko-bekhta could you try rebasing your PR on this one and see if you can sort out the dependencies now? I mean your PR that adds a management interface to Hibernate Search.

[marko-bekhta]

@yrodiere done 😃 I've tried these changes locally and it seems to be working OK, so I've also pushed it to see if the CI will also be happy #35065
@cescoffier thanks! 😃

[quarkus-bot]

Failing Jobs - Building 50c898b

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✔️	JVM Tests - JDK 17					🔍
✖	JVM Tests - JDK 21	Build	Failures	Logs	Raw logs	🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: extensions/scheduler/deployment 
! Skipped: extensions/quartz/deployment extensions/spring-scheduled/deployment integration-tests/main and 7 more

📦 extensions/scheduler/deployment

✖ io.quarkus.scheduler.test.PausedSchedulerTest.testSchedulerPauseResume line 47 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertFalse.failNotFalse(AssertFalse.java:63)
	at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:36)
	at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:31)
	at org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:231)
	at io.quarkus.scheduler.test.PausedSchedulerTest.testSchedulerPauseResume(PausedSchedulerTest.java:47)

[gsmet]

I added a question that I want us to sort out before merging.

It might just be me being overcautious :).

[gsmet]

Do we really want to add this dependency? The idea would be to not depend on anything Vert.x right?

[yrodiere]

I don't know if it's necessary, but as far as I'm concerned, it's fine. A mandatory dependency in the deployment artifact is acceptable as long as it can be optional at runtime (and from what I see in Marko 's PR, it can be).

[yrodiere]

(to clarify, the initial goal was to make the dependency optional at runtime, though Clément may have gone a bit further here)

[mkouba]

Hm, I believe that build items should be immutable. In theory, the build item producer can (even mistakenly) modify the build item through the builder after it's produced and that may lead to unexpected errors.

[cescoffier]

You're right. I did that for simplicity, but I should use the builder to keep everything and build an immutable route build item.