Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC: introduce quarkus.arc.optimize-contexts=auto #38121

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 10, 2024

  • if "auto" is used then only optimize if there is less than 1000 beans in the app; removed beans are excluded
  • use this as the default value

@mkouba mkouba requested review from Ladicek and manovotn January 10, 2024 10:57
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Jan 10, 2024
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically you could use Predicate<BeanDeployment> instead of Function<BeanDeployment, Boolean>, but LGTM otherwise!

@mkouba
Copy link
Contributor Author

mkouba commented Jan 10, 2024

Technically you could use Predicate<BeanDeployment> instead of Function<BeanDeployment, Boolean>, but LGTM otherwise!

Ah, good point about the predicate! I'll send an update shortly.

- if "auto" is used then only optimize if there is less than 1000 beans
in the app; removed beans are excluded
- use this as the default value
@mkouba mkouba force-pushed the arc-optimize-contexts-auto branch from 91fd627 to 02e10fa Compare January 10, 2024 11:17
@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 10, 2024
Copy link

quarkus-bot bot commented Jan 10, 2024

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit 4177598 into quarkusio:main Jan 10, 2024
50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 10, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants