Fix NPE and otel quickstart test #38087
Conversation
|
/cc @radcortez (opentelemetry) |
| @@ -373,6 +373,7 @@ | |||
| <module>micrometer-mp-metrics</module> | |||
| <module>micrometer-prometheus</module> | |||
| <module>opentelemetry</module> | |||
| <module>opentelemetry-quickstart</module> | |||
There was a problem hiding this comment.
Do we really need a new module for this? Is there no existing module we can use?
There was a problem hiding this comment.
Unfortunately no, because all the existing apps try to inject OTel stuff to help with the tests (like Baggage) and they will fail if OTel is disabled.
There was a problem hiding this comment.
Some of the test apps could probably be refactored with this objective but this is not the first time a bug is found on the quickstart, therefore I thought it would be worthwhile.
This comment has been minimized.
This comment has been minimized.
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. You can consult the Develocity build scans. |
Fixes #38084.
Added IT for the simplest quickstart project