-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Final edits, Style enhancements, Vale checks #38024
Conversation
🎊 PR Preview b776e87 has been successfully built and deployed to https://quarkus-pr-main-38024-preview.surge.sh/version/main/guides/ |
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
Thanks @sheilamjones, can you please push the latest updates ? |
c5f638e
to
78249a9
Compare
@sberyozkin Hello there! I will review it soon and that we are good to go! |
Hi @MichalMaler, sure, will wait, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Nice work.
@sheilamjones , here I am sending some suggestions that I could add directly to your PR.
|
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-code-flow-authentication-tutorial.adoc
Show resolved
Hide resolved
@sheilamjones @sberyozkin Hello! |
78249a9
to
64232e8
Compare
@sberyozkin, thanks again for your review. I believe this one is ready to merge. |
There seem to be some conflicts.. :/ |
64232e8
to
bd70278
Compare
Hi @jmartisk, apologies, I'm not sure what happened there. Many thanks for looking at this PR. I have fixed all the conflicts and it is running through the final build checks now and should be ready then to merge. |
All looks good now, thanks |
Thanks so much @jmartisk. Much appreciated. |
This PR fixes style issues (title capitalization, one sentence per line...), links, Vale issues, and some grammar as per the preferred Quarkus Contributor guidelines in the security-oidc-code-flow-authentication-tutorial.adoc (Protect a web application by using OpenID Connect (OIDC) authorization code flow guide)
Reference: QDOCS-570