Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Final edits, Style enhancements, Vale checks #38024

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

sheilamjones
Copy link
Contributor

@sheilamjones sheilamjones commented Jan 4, 2024

This PR fixes style issues (title capitalization, one sentence per line...), links, Vale issues, and some grammar as per the preferred Quarkus Contributor guidelines in the security-oidc-code-flow-authentication-tutorial.adoc (Protect a web application by using OpenID Connect (OIDC) authorization code flow guide)

Reference: QDOCS-570

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

🎊 PR Preview b776e87 has been successfully built and deployed to https://quarkus-pr-main-38024-preview.surge.sh/version/main/guides/

@sberyozkin
Copy link
Member

Thanks @sheilamjones, can you please push the latest updates ?

@sheilamjones sheilamjones force-pushed the QDOCS-570-finalchecks branch from c5f638e to 78249a9 Compare January 4, 2024 16:18
@MichalMaler
Copy link
Contributor

@sberyozkin Hello there! I will review it soon and that we are good to go!
Will ping ya when ready :)

@sberyozkin sberyozkin self-requested a review January 4, 2024 17:14
@sberyozkin
Copy link
Member

Hi @MichalMaler, sure, will wait, thanks

Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work.

@rolfedh rolfedh removed the request for review from MichalMaler January 4, 2024 17:47
@MichalMaler
Copy link
Contributor

MichalMaler commented Jan 4, 2024

@sheilamjones , here I am sending some suggestions that I could add directly to your PR.

  1. Line 178: (missing comma)
    The quarkus.oidc.client-id property references the client_id issued by the OIDC provider, and the quarkus.oidc.credentials.secret property sets the client secret.

  2. Line 180: (minimalism/grammar)
    The quarkus.oidc.application-type property is set to web-app to tell Quarkus that you want to enable the OIDC authorization code flow so your users are redirected to the OIDC provider to authenticate.

@MichalMaler
Copy link
Contributor

@sheilamjones @sberyozkin Hello!
Added few little suggestions. Looks great overall. Feel free to apply or merge.
Cheers!

@sheilamjones sheilamjones force-pushed the QDOCS-570-finalchecks branch from 78249a9 to 64232e8 Compare January 5, 2024 09:43
@sheilamjones
Copy link
Contributor Author

@sberyozkin, thanks again for your review. I believe this one is ready to merge.

@jmartisk
Copy link
Contributor

There seem to be some conflicts.. :/

@sheilamjones sheilamjones force-pushed the QDOCS-570-finalchecks branch from 64232e8 to bd70278 Compare January 12, 2024 11:19
@sheilamjones
Copy link
Contributor Author

Hi @jmartisk, apologies, I'm not sure what happened there. Many thanks for looking at this PR. I have fixed all the conflicts and it is running through the final build checks now and should be ready then to merge.
Many thanks,
Sheila

@jmartisk
Copy link
Contributor

All looks good now, thanks

@jmartisk jmartisk merged commit 2767d66 into quarkusio:main Jan 12, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 12, 2024
@sheilamjones
Copy link
Contributor Author

Thanks so much @jmartisk. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
Development

Successfully merging this pull request may close these issues.

5 participants