Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expand config properties for Gradle Workers #37987

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

radcortez
Copy link
Member

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Jan 2, 2024
@radcortez
Copy link
Member Author

Maybe it is also required for

@TaskAction
public void generateCode() {
ApplicationModel appModel = extension().getApplicationModel(launchMode);
Map<String, String> configMap = extension().buildEffectiveConfiguration(appModel.getAppArtifact()).configMap();
File outputPath = getGeneratedOutputDirectory().get().getAsFile();
getLogger().debug("Will trigger preparing sources for source directories: {} buildDir: {}",
sourcesDirectories, buildDir.getAbsolutePath());
WorkQueue workQueue = workQueue(configMap, () -> extension().codeGenForkOptions);
workQueue.submit(CodeGenWorker.class, params -> {
params.getBuildSystemProperties().putAll(configMap);
params.getBaseName().set(extension().finalName());
params.getTargetDirectory().set(buildDir);
params.getAppModel().set(appModel);
params
.getSourceDirectories()
.setFrom(sourcesDirectories.stream().map(Path::toFile).collect(Collectors.toList()));
params.getOutputPath().set(outputPath);
params.getLaunchMode().set(launchMode);
params.getGradleVersion().set(getProject().getGradle().getGradleVersion());
});
workQueue.await();
}
.

Since it didn't have the quarkus prefix filter like QuarkusBuildTask, I've left it untouched.

Copy link

quarkus-bot bot commented Jan 2, 2024

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment variable is not read
4 participants