Expose pandaproxy port in Redpanda dev services #37972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
stephan-strate
force-pushed
the
redpanda-pandaproxy
branch
from
61d0753 to
db323e0
Compare
This comment has been minimized.
This comment has been minimized.
|
@stephan-strate thanks for your PR. Can you please run |
stephan-strate
force-pushed
the
redpanda-pandaproxy
branch
from
db323e0 to
2b8f759
Compare
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
stephan-strate
force-pushed
the
redpanda-pandaproxy
branch
from
2b8f759 to
fd358d3
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
cescoffier
approved these changes
Jan 2, 2024
geoand
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed the pandaproxy port 8082 to a random port by default, added configuration parameter to fix the port. Are there any tests for the kafka redpanda devservice? I could not find any.
I have also changed the naming from "Red Panda" to "Redpanda" as this seemed to be inconsistent. Let me know, if I should revert this change.
Also quick note for redpanda: The vectorized/redpanda image seems to be deprecated (https://hub.docker.com/r/vectorized/redpanda).
Resolves #37970