Scheduler: support skip predicate class with public no-args constructor #37829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Dec 19, 2023
mkouba
commented
- it does not need to represent a CDI bean anymore
- add JobDefinition#skipPredicate() variant that accepts a class
This comment has been minimized.
This comment has been minimized.
- it does not need to represent a CDI bean anymore - add JobDefinition#skipPredicate() variant that accepts a class
mkouba
force-pushed
the
scheduler-skip-predicate-class
branch
from
155f8ec to
c30150d
Compare
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
gsmet
reviewed
Dec 22, 2023
| try { | ||
| return type.getConstructor().newInstance(); | ||
| } catch (Exception e) { | ||
| throw new IllegalStateException("Unable to instantiate the class: " + type); |
There was a problem hiding this comment.
I will merge this but I wonder if we will regret to not have included the expection as a cause :).
gsmet
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.