Introduce env variable QUARKUS_NATIVE_IT_SKIP_VERIFY_IMAGE_METRICS #37820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
geoand
approved these changes
Dec 19, 2023
| * Allow users to skip this kind of tests by setting env variable QUARKUS_NATIVE_IT_SKIP_VERIFY_IMAGE_METRICS to true | ||
| */ | ||
| String skipVerifyImageMetrics = System.getenv("QUARKUS_NATIVE_IT_SKIP_VERIFY_IMAGE_METRICS"); | ||
| boolean skip = skipVerifyImageMetrics != null && skipVerifyImageMetrics.equalsIgnoreCase("true"); |
There was a problem hiding this comment.
Minor nitpicking: you can use Boolean.valueOf here
There was a problem hiding this comment.
Done, using Boolean.parseBoolean though since there is no need for the variable to be a Boolean instead of a boolean.
jerboaa
approved these changes
Dec 19, 2023
Allow users to skip tests verifying native image build metrics (such as binary size, classes registered for reflection, etc.) by setting env variable QUARKUS_NATIVE_IT_SKIP_VERIFY_IMAGE_METRICS to true. Quarkus uses the "jvmci" version from the base-JDK used to build GraalVM. When building GraalVM master with JDK 21, however, we are using LabsJDK 21.0.1+12-jvmci-23.1-b26, so Quarkus thinks the GraalVM version is 23.1 despite it acutally being 24.0. Since upstream GraalVM doesn't plan on releasing GraalVM 24.0 based on JDK 21 it's not expected to get a jvmci version bump in LabsJDK 21. This patch allows us to keep testing GraalVM 24.0-dev with JDK 21 without getting false negatives.
zakkak
force-pushed
the
2023-12-18-opt-out-from-metrics-it
branch
from
d92738c to
21f055a
Compare
zakkak
added
the
triage/waiting-for-ci
jerboaa
approved these changes
Dec 19, 2023
|
Failures are due to: The ImageMetricsITCase seems to work as expected. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to skip tests verifying native image build metrics (such as
binary size, classes registered for reflection, etc.) by setting env
variable QUARKUS_NATIVE_IT_SKIP_VERIFY_IMAGE_METRICS to true.
Quarkus uses the "jvmci" version from the base-JDK used to build
GraalVM. When building GraalVM master with JDK 21, however, we are using
LabsJDK 21.0.1+12-jvmci-23.1-b26, so Quarkus thinks the GraalVM version
is 23.1 despite it acutally being 24.0. Since upstream GraalVM doesn't
plan on releasing GraalVM 24.0 based on JDK 21 it's not expected to get
a jvmci version bump in LabsJDK 21.
This patch allows us to keep testing GraalVM 24.0-dev with JDK 21 without
getting false negatives.