Edit security-getting-started-tutorial.adoc #37817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/docstyle
|
🙈 The PR is closed and the preview is expired. |
sberyozkin
reviewed
Dec 18, 2023
sberyozkin
reviewed
Dec 18, 2023
sberyozkin
reviewed
Dec 18, 2023
sberyozkin
reviewed
Dec 18, 2023
|
Thanks @rolfedh LGTM, a couple of open questions but otherwise a nice update as always |
sberyozkin
approved these changes
Dec 20, 2023
|
@rolfedh Are you awaiting for more reviews or is it ready to be merged ? |
|
@sberyozkin Hello there! I will review it soon and that we are good to go! |
MichalMaler
approved these changes
Jan 4, 2024
|
@rolfedh @sberyozkin My review is done. Looks good! |
|
Thanks @rolfedh @MichalMaler, as it happens, in meantime, the PR I created earlier in response to the QE doc review has been merged, so Rolfe, please resolve the conflict |
|
Thank you for your review, @MichalMaler! |
MichalMaler
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References https://issues.redhat.com/browse/QDOCS-564