Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to java docs from java 11 to java 17 #37800

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

jedla97
Copy link
Contributor

@jedla97 jedla97 commented Dec 17, 2023

As Quarkus move from java 11+ to java 17+ the links for java docs should be updated as well. These should be all
occurrences containing javase/11 keyword. Tested it and all new links works.

@quarkus-bot quarkus-bot bot added area/core area/docstyle issues related for manual docstyle review area/documentation area/graphics labels Dec 17, 2023
Copy link

quarkus-bot bot commented Dec 17, 2023

/cc @Karm (awt), @galderz (awt)

Copy link

github-actions bot commented Dec 17, 2023

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

Copy link

quarkus-bot bot commented Dec 18, 2023

Failing Jobs - Building cc1b001

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 🚧
JVM Tests - JDK 21 Build Failures Logs Raw logs 🚧
Native Tests - Data4 Update Docker Client User Agent ⚠️ Check → Logs Raw logs 🚧

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: devtools/cli 

📦 devtools/cli

io.quarkus.cli.CliHelpTest.testCommandHelp line 34 - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

@gsmet gsmet merged commit 3dc6967 into quarkusio:main Dec 18, 2023
50 of 52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants