-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SmallRye Config to 3.5.1 #37794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/arc
Issue related to ARC (dependency injection)
area/config
area/core
area/dependencies
Pull requests that update a dependency file
labels
Dec 17, 2023
radcortez
force-pushed
the
sr-config-3.5.0
branch
2 times, most recently
from
December 23, 2023 00:20
e1d5db3
to
fae688a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
radcortez
force-pushed
the
sr-config-3.5.0
branch
from
January 2, 2024 22:46
fae688a
to
ac9cef6
Compare
quarkus-bot
bot
added
area/devtools
Issues/PR related to maven, gradle, platform and cli tooling/plugins
area/gradle
Gradle
labels
Jan 2, 2024
This comment has been minimized.
This comment has been minimized.
radcortez
changed the title
Update SmallRye Config to 3.5.0
Update SmallRye Config to 3.5.1
Jan 3, 2024
geoand
approved these changes
Jan 3, 2024
Mind rebasing to get one more run on the latest main? |
Sure |
radcortez
force-pushed
the
sr-config-3.5.0
branch
from
January 3, 2024 11:24
ac9cef6
to
6053da3
Compare
Amazing work @radcortez and thanks for the very detailed description. |
geoand
added
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Jan 3, 2024
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Ready to merge when CI successfully finishes
labels
Jan 3, 2024
Thanks :) Let's hope it doesn't cause too many regressions. |
what change exactly @radcortez ? |
This one: smallrye/smallrye-config#1026 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/arc
Issue related to ARC (dependency injection)
area/config
area/core
area/dependencies
Pull requests that update a dependency file
area/devtools
Issues/PR related to maven, gradle, platform and cli tooling/plugins
area/gradle
Gradle
kind/bugfix
release/noteworthy-feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are significant changes in the SR Config implementation, including a complete rewrite of the
@ConfigMapping
implementation to be fully build-time aware.Used
config-quickstart
to measure improvements with Java 17 Temurin and Graal 22.3 - Java 17:Some corner case mappings may not work, due to the major implementation changes. This is not intended, and I'll fix those if they show up. The changes were made to retain 100% compatibility with the old implementation. There are likely cases we are not covering in our tests, hence the warning.
Due to a change triggered by #35410, the config file loader now looks for any associated extension in the loader (if multiple available) smallrye/smallrye-config#1026. This was causing issues with the Gradle plugin, which provided a custom loader implementation plus used the same ordinal for both
properties
andyaml
files, which is not how Quarkus, and Maven order these sources. The Gradle plugin was adjusted to be consistent with ordering sources in other systems. Some Gradle users can notice configuration differences if they are mixingproperties
andyaml
files.