Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC: improve error message for unsatisfied dependency #37774

Merged
merged 1 commit into from
Dec 18, 2023
Merged

ArC: improve error message for unsatisfied dependency #37774

merged 1 commit into from
Dec 18, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Dec 15, 2023 •
edited
Loading

  • in particular, the message is improved when a user attempts to inject a bean class:
    (a) that has no bean defining annotation.
    (b) is vetoed
    (c) is excluded in config
    (d) does not declare a valid bean constructor
    (e) has the matched type excluded by the Typed annotation

Fixes #33485

@mkouba
ArC: improve error message for unsatisfied dependency
7622aac 
- in particular, the message is improved when a user attempts to inject
a bean class:
(a) that has no bean defining annotation.
(b) is vetoed
(c) is excluded in config
(d) does not declare a valid bean constructor
(e) has the matched type excluded by the Typed annotation
@mkouba mkouba requested review from manovotn and Ladicek and removed request for manovotn December 15, 2023 12:23
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Dec 15, 2023
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Dec 15, 2023

Failing Jobs - Building 7622aac

Status Name Step Failures Logs Raw logs Build scan
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs 🚧
✖ JVM Tests - JDK 21 Build Failures Logs Raw logs 🚧
✖ Native Tests - Data5 Update Docker Client User Agent ⚠️ Check → Logs Raw logs 🚧

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: devtools/cli

📦 devtools/cli

✖ io.quarkus.cli.CliHelpTest.testCommandHelp line 34 - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ JVM Tests - JDK 21 #

- Failing: devtools/cli

📦 devtools/cli

✖ io.quarkus.cli.CliHelpTest.testCommandHelp line 34 - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

@mkouba mkouba merged commit bedabdd into quarkusio:main Dec 18, 2023
46 of 49 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Dec 18, 2023
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

@Ladicek Ladicek Awaiting requested review from Ladicek

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) kind/enhancement New feature or request
Projects
None yet
Milestone
3.7.0.CR1
Development

Successfully merging this pull request may close these issues.

ArC - improve the error message for unsatisfied dependency
2 participants
@mkouba @manovotn