-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve OIDC code flow concept document #37689
Improve OIDC code flow concept document #37689
Conversation
🙈 The PR is closed and the preview is expired. |
Hi Sergey. Fedor is on Christmas PTO already, he will be back in January. |
Hi Rostislav, sure, sounds good, FYI I'll be totally offline the week starting 8th Jan, but UserInfo related doc updates can be handled separately if we won't address them earlier |
f735de2
to
0363cdf
Compare
@fedinskiy FYI, the large session cookie issue is addressed in #37891, which has already been approved by @gastaldi, so it is ready to go pending some possible comments from Pedro. I plan to merge in the evening of 3rd Jan or 4th Jan morning at the latest, so then it would be possible to verify it fixed the issue in your reproducer as well CC @rsvoboda |
@sberyozkin do you still need clarification regarding large session cookie? |
@fedinskiy I'm certain #37891 will resolve it, so if you are OK with it, your comment about it can be considered resolved and then once #37891 is merged, you can double check it if you will have time, does it sound reasonable ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, @fedinskiy told me he was OK with the changes.
Thanks @fedinskiy @rsvoboda |
Fixes #37422
Keeping in a draft state for now, @fedinskiy, please clarify how did you reproduce a too large session cookie issue with UserInfo