Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OIDC code flow concept document #37689

Merged

Conversation

sberyozkin
Copy link
Member

Fixes #37422

Keeping in a draft state for now, @fedinskiy, please clarify how did you reproduce a too large session cookie issue with UserInfo

@sberyozkin sberyozkin requested a review from rsvoboda December 12, 2023 12:53
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Dec 12, 2023
Copy link

github-actions bot commented Dec 12, 2023

🙈 The PR is closed and the preview is expired.

@rsvoboda
Copy link
Member

Hi Sergey. Fedor is on Christmas PTO already, he will be back in January.

@sberyozkin
Copy link
Member Author

Hi Rostislav, sure, sounds good, FYI I'll be totally offline the week starting 8th Jan, but UserInfo related doc updates can be handled separately if we won't address them earlier

@sberyozkin sberyozkin force-pushed the improve_oidc_code_flow_concept_doc branch from f735de2 to 0363cdf Compare December 21, 2023 16:22
@sberyozkin sberyozkin marked this pull request as ready for review December 21, 2023 16:22
@sberyozkin
Copy link
Member Author

@fedinskiy FYI, the large session cookie issue is addressed in #37891, which has already been approved by @gastaldi, so it is ready to go pending some possible comments from Pedro. I plan to merge in the evening of 3rd Jan or 4th Jan morning at the latest, so then it would be possible to verify it fixed the issue in your reproducer as well

CC @rsvoboda

@fedinskiy
Copy link
Contributor

@sberyozkin do you still need clarification regarding large session cookie?

@sberyozkin
Copy link
Member Author

@fedinskiy I'm certain #37891 will resolve it, so if you are OK with it, your comment about it can be considered resolved and then once #37891 is merged, you can double check it if you will have time, does it sound reasonable ?

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, @fedinskiy told me he was OK with the changes.

@rsvoboda rsvoboda merged commit 6cef0d5 into quarkusio:main Jan 3, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 3, 2024
@sberyozkin sberyozkin deleted the improve_oidc_code_flow_concept_doc branch January 4, 2024 18:42
@sberyozkin
Copy link
Member Author

Thanks @fedinskiy @rsvoboda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation kind/bugfix
Projects
Development

Successfully merging this pull request may close these issues.

Docs: OpenID Connect authorization code flow mechanism
3 participants