Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use run-java script when possible #37647

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 11, 2023

When creating a container image using Jib,
try to use the run-java script when
it exists and when AppCDS are not being
used

When creating a container image using Jib,
try to use the run-java script when
it exists and when AppCDS are not being
used
@shivam-sharma7
Copy link
Contributor

@geoand will this affect who already using jib to build container images?

@geoand
Copy link
Contributor Author

geoand commented Dec 11, 2023

Yes

@shivam-sharma7
Copy link
Contributor

Yes

then it is comming in next quarkus 3.6.2 right?

@cescoffier
Copy link
Member

I would say 3.7.

@cescoffier
Copy link
Member

(@geoand we should document it as a breaking change and how to configure the entry point)

@shivam-sharma7
Copy link
Contributor

Thanks @cescoffier

@geoand
Copy link
Contributor Author

geoand commented Dec 11, 2023

(@geoand we should document it as a breaking change and how to configure the entry point)

Definitely.

Copy link

quarkus-bot bot commented Dec 11, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 4ad3038 into quarkusio:main Dec 11, 2023
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 11, 2023
@geoand geoand deleted the jib-run-java branch December 11, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants