-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Using OpenID Connect (OIDC) multitenancy #37584
Conversation
I expect to push a few updates to the PR over the next hour, after the CI "[vale] reported by reviewdog" tool generates some additional warnings. |
Okay, I'm done pushing changes in response to "reviewdog." This PR is ready for review. |
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
Hello @rolfedh . |
🙈 The PR is closed and the preview is expired. |
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
Thanks a bunch, @MichalMaler! Your suggestions were spot on and really helpful. Just to loop you in, as we chatted with @sberyozkin and also covered in today's meeting, we're planning to tackle the line breaks as a separate step. |
@sberyozkin I have finished applying @MichalMaler's peer review suggestions. This draft is ready for your review. |
d024c55
to
d8b842b
Compare
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
Hi @rolfedh A lot of good cleanup here, thanks, a few minor suggestions and comments there from me, but overall, very nice, thanks |
233780f
to
df8456b
Compare
@sberyozkin If you approve, I believe this is ready for merge. |
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
@rolfedh Added a little tweaks. Feel free to merge when @sberyozkin provides us with the green one. |
This PR is ready for a final review by @sberyozkin. Thanks. |
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
@rolfedh LGTM overall, minor suggestions proposed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sberyozkin Thank you for your review comments. I've made updates accordingly. Please let me know if any further improvements are needed.
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rolfedh
Purpose: Edit Using OpenID Connect (OIDC) multitenancy
References QDOCS-556