Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make REST Client a bean when the scope property is set in config #37580

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 7, 2023

This comment has been minimized.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a comment on the javadoc of the new property. I think we should indicate the default if unset.

This comment has been minimized.

@cescoffier
Copy link
Member

someone forgot to run the formatter ... @geoand :-D

@geoand
Copy link
Contributor Author

geoand commented Dec 7, 2023

Happens to me everytime :)

Copy link

quarkus-bot bot commented Dec 7, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit c93b469 into quarkusio:main Dec 7, 2023
29 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Dec 7, 2023
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 7, 2023
@geoand geoand deleted the #37007 branch December 8, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants