Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the container-image-s2i extension #37489

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Dec 4, 2023

@iocanel this is a first pass at it. I will create it as draft to check what CI says.

@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/kubernetes labels Dec 4, 2023
@gsmet gsmet requested a review from iocanel December 4, 2023 14:14
@gsmet gsmet marked this pull request as ready for review December 8, 2023 12:22
@gsmet
Copy link
Member Author

gsmet commented Dec 8, 2023

@iocanel CI was green in my fork and this should be ready for review. Thanks!

Copy link

quarkus-bot bot commented Dec 8, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iocanel iocanel merged commit b48452c into quarkusio:main Dec 11, 2023
63 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/kubernetes
Projects
Development

Successfully merging this pull request may close these issues.

2 participants