Use --interactive option when using docker inside Windows' WSL

[zakkak]

There seems to be an issue with docker printing output when running in Windows' WSL without --interactive.

Closes #37272
Closes #32215

[zakkak]

@tglaeser @gmuellerinform can you please confirm that the docker info output contains WSL in your environments?

If you could also give this PR a go it would be great. You can do so by running:

git clone https://github.com/zakkak/quarkus --branch 2023-11-27-fix-docker-in-wsl-issue
cd quarkus
./mvnw -Dquickly
./mvnw -Dnative -pl integration-tests/jpa -Dnative.surefire.skip -Dformat.skip -Dno-descriptor-tests clean verify

[zakkak]

@Karm @geoand please note that I am also moving ContainerRuntimeUtil to core/deployment since it's only used in the deployment phase. I am not sure why it was added to core/runtime at first. Let me know if there is any issue with the move.

[tglaeser]

Executing docker info in terminal applications CMD, PowerShell, MSYS2, and the Kali Linux WSL VE terminal all contain output

...
 Kernel Version: 5.15.133.1-microsoft-standard-WSL2
 Operating System: Rancher Desktop WSL Distribution
...

[tglaeser]

./mvnw -Dnative -pl integration-tests/jpa -Dnative.surefire.skip -Dformat.skip -Dno-descriptor-tests clean verify

returns

[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.203 s -- in io.quarkus.it.jpa.entitylistener.EntityListenerInGraalITCase
[INFO] Running io.quarkus.it.jpa.generatedvalue.GeneratedValueInGraalITCase
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.010 s -- in io.quarkus.it.jpa.generatedvalue.GeneratedValueInGraalITCase
[INFO] Running io.quarkus.it.jpa.jdbcmetadata.JPAJdbcMetadataRetrievalInGraalITCase
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 s -- in io.quarkus.it.jpa.jdbcmetadata.JPAJdbcMetadataRetrievalInGraalITCase
[INFO] H2 database was shut down; server status: Not started
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- failsafe:3.1.2:verify (default) @ quarkus-integration-test-jpa ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:20 min
[INFO] Finished at: 2023-11-29T14:29:37-05:00
[INFO] ------------------------------------------------------------------------
[INFO] 20 goals, 20 executed

Probably unrelated, there were many exceptions of type Caused by: org.h2.jdbc.JdbcSQLSyntaxErrorException: Schema "SCHEMA1" not found thrown wile executing those test cases.

[gsmet]

@zakkak the question might be stupid but won't --interactive makes things... well... interactive? :)

[zakkak]

@zakkak the question might be stupid but won't --interactive makes things... well... interactive? :)

I suppose, but it's not clear what this really means in our case. According to my testing it doesn't seem to affect the build process (at least not when everything works as expected) and AFAIK is the only way to work around the issue. I guess it could become an issue if native-image suddenly decides to ask for some input at any stage of the build process :/

[quarkus-bot]

Failing Jobs - Building 0af4d6a

Status	Name	Step	Failures	Logs	Raw logs	Build scan
❓	Build scans		⚠️ Check →			🚧
✔️	JVM Tests - JDK 11					🔍
✔️	JVM Tests - JDK 17					🔍
✖	JVM Tests - JDK 17 Windows	Build	Failures	Logs	Raw logs	🔍
✔️	JVM Tests - JDK 21					🔍

Full information is available in the Build summary check run.
You can also consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/elytron-security-ldap/deployment 
! Skipped: integration-tests/elytron-security-ldap 

📦 extensions/elytron-security-ldap/deployment

✖ io.quarkus.elytron.security.ldap.FormAuthTest.testJaxrsPathAdminRoleSuccess - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <403>.

[zakkak]

@gsmet if there are no objections on your side I think this is ready to be merged.

[gsmet]

Let's merge and we will see how it goes. I was worried that maybe it would ask things with a prompt or whatever but we'll see in practice if we get reports.