Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type for EncoderMode used in rest-client #37262

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

luca-bassoricci
Copy link
Contributor

@luca-bassoricci luca-bassoricci commented Nov 22, 2023

Used PausableHttpPostRequestEncoder.EncoderMode instead of io.netty.handler.codec.http.multipart.HttpPostRequestEncoder.EncoderMode

I have removed all references to Netty's EncoderMode in favor of PausableHttpPostRequestEncoder's ones

Fix #37261

Copy link

quarkus-bot bot commented Nov 22, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@luca-bassoricci luca-bassoricci changed the title Wrong type for EncoderMode used in rest-client (#37261) Wrong type for EncoderMode used in rest-client Nov 22, 2023
@gsmet
Copy link
Member

gsmet commented Nov 22, 2023

@luca-bassoricci would it be easy to add a small test in the -deployment module of the extension?

@luca-bassoricci
Copy link
Contributor Author

@luca-bassoricci would it be easy to add a small test in the -deployment module of the extension?

test added

@luca-bassoricci luca-bassoricci force-pushed the issue_encodermode branch 2 times, most recently from 5b0ad13 to c367d20 Compare November 24, 2023 07:20

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Nov 29, 2023

Can you please squash and rebase the commits when you are done?

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/cli Related to quarkus cli (not maven/gradle/etc.) area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/gradle Gradle area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/maven area/metrics area/oidc area/panache area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform labels Nov 29, 2023
@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed area/gradle Gradle area/core area/arc Issue related to ARC (dependency injection) area/maven area/security area/resteasy-classic area/vertx area/testing area/hibernate-orm Hibernate ORM area/oidc area/spring Issues relating to the Spring integration area/platform Issues related to definition and interaction with Quarkus Platform area/hibernate-search Hibernate Search area/dependencies Pull requests that update a dependency file area/qute The template engine area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/metrics area/cli Related to quarkus cli (not maven/gradle/etc.) area/rest area/docstyle issues related for manual docstyle review triage/backport? labels Nov 29, 2023
Copy link

quarkus-bot bot commented Nov 29, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 44876a3 into quarkusio:main Nov 29, 2023
32 checks passed
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Nov 29, 2023
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Nov 29, 2023
@luca-bassoricci luca-bassoricci deleted the issue_encodermode branch November 30, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

ClassCastException in PausableHttpPostRequestEncoder for custom encoder-mode in configuration
3 participants