Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make testLambdaCapturing test conditional on GraalVM version #37063

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Nov 14, 2023

Starting with GraalVM 24.0 lambda class names match the ones from HotSpot.

Closes #37037

Being tested against GraalVM CE 24.0-dev in https://github.com/graalvm/mandrel/actions/runs/6860951487

@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/testing labels Nov 14, 2023
The parseable version is in `metadata.graalvm.version.full` not in
`metadata.graalvm.version.version`.
Starting with GraalVM 24.0 lambda class names match the ones from
HotSpot.
@zakkak zakkak force-pushed the 2023-11-14-fix-main-it branch from 4d6bdc9 to 4f6c97e Compare November 14, 2023 08:23
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 14, 2023
@zakkak
Copy link
Contributor Author

zakkak commented Nov 14, 2023

Being tested against GraalVM CE 24.0-dev in https://github.com/graalvm/mandrel/actions/runs/6860951487

CI runs with 24.0-dev look good (the simple with space failure is tracked in #36998)

Copy link

quarkus-bot bot commented Nov 14, 2023

Failing Jobs - Building 4f6c97e

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 21 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: extensions/micrometer/deployment 
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/quartz/deployment extensions/scheduler/deployment and 25 more

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.binder.VertxHttpClientMetricsTest.testWebClientMetrics line 56 - More details - Source on GitHub

java.util.concurrent.CompletionException: java.net.BindException: Address already in use
	at io.smallrye.mutiny.operators.uni.UniBlockingAwait.await(UniBlockingAwait.java:79)
	at io.smallrye.mutiny.groups.UniAwait.atMost(UniAwait.java:65)

@zakkak zakkak merged commit c1af049 into quarkusio:main Nov 14, 2023
50 of 51 checks passed
@zakkak zakkak deleted the 2023-11-14-fix-main-it branch November 14, 2023 21:36
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Nov 14, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/testing kind/bugfix
Projects
None yet
3 participants