Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dynamically resolved Java version when creating Gradle projects #37051

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Use dynamically resolved Java version when creating Gradle projects #37051

merged 1 commit into from
Nov 14, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Nov 13, 2023

Also add tests for Java 21.
Fixes #37047

@gsmet gsmet requested review from gastaldi and ia3andy November 13, 2023 16:35
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels Nov 13, 2023
@gsmet gsmet mentioned this pull request Nov 13, 2023
Closed
ia3andy
ia3andy approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ia3andy
Copy link
Contributor

ia3andy commented Nov 13, 2023

But is it ok to have this: https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus/tooling/dockerfiles/base/Dockerfile-layout.include.qute#L80

@gsmet
Copy link
Member Author

gsmet commented Nov 13, 2023

For now, I don't think we have Java 21 images unfortunately but @cescoffier should know more.

@ia3andy
Copy link
Contributor

ia3andy commented Nov 13, 2023 •
edited
Loading

For now, I don't think we have Java 21 images unfortunately but @cescoffier should know more.

That's why I suggested not to allow Java 21 yet

@ia3andy
Copy link
Contributor

ia3andy commented Nov 13, 2023

Maybe we could find a solution and put a warning on something in the dockerfiles?

@cescoffier
Copy link
Member

We are waiting for the image. I heard that should be ready in November.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 14, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet
Copy link
Member Author

gsmet commented Nov 14, 2023

@ia3andy feel free to do something about it but we would have to revert very soon. We have allowed 21 in Maven for a while and we haven't heard any complaints (yet...). I agree the situation is not perfect but people are eager to use 21 and forbidding them to do it looks like a bad bet to me - even if some pieces are unfortunately missing.

I will merge this one, feel free to follow up.

@gsmet gsmet merged commit c570268 into quarkusio:main Nov 14, 2023
50 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

@gastaldi gastaldi Awaiting requested review from gastaldi

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform kind/bugfix
Projects
None yet
Milestone
3.6.0.CR1
Development

Successfully merging this pull request may close these issues.

Quarkus CLI doesn't honor --java=21 for gradle projects
3 participants
@gsmet @ia3andy @cescoffier