Final edits and Vale fixes in OIDC authorization code flow mechanism for protecting web applications guide for 3.2 #37024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/docstyle
|
🙈 The PR is closed and the preview is expired. |
sberyozkin
reviewed
Nov 11, 2023
|
|
||
| But if you already have all the required `quarkus-oidc` properties configured then you only need to associate `quarkus.oidc.auth-server-url` with the `prod` profile for `Dev Services for Keycloak`to start a container, for example: | ||
| However, if you already have all the required `quarkus-oidc` properties configured, then you only need to associate `quarkus.oidc.auth-server-url` with the `prod` profile for `Dev Services for Keycloak`to start a container, for example: |
There was a problem hiding this comment.
Suggested change
| However, if you already have all the required `quarkus-oidc` properties configured, then you only need to associate `quarkus.oidc.auth-server-url` with the `prod` profile for `Dev Services for Keycloak`to start a container, for example: | |
| However, if you already have all the required `quarkus-oidc` properties configured, then you only need to associate `quarkus.oidc.auth-server-url` with the `prod` profile for `Dev Services for Keycloak` to start a container, for example: |
There was a problem hiding this comment.
Good catch, thank you.
sberyozkin
reviewed
Nov 11, 2023
| @@ -1466,19 +1485,20 @@ Additionally, `OidcWiremockTestResource` set token issuer and audience to `https | |||
| [[integration-testing-keycloak-devservices]] | |||
| === Dev services for Keycloak | |||
|
|
|||
| Using xref:security-openid-connect-dev-services.adoc[Dev Services for Keycloak] is recommended for the integration testing against Keycloak. | |||
| `Dev Services for Keycloak` will launch and initialize a test container: it will create a `quarkus` realm, a `quarkus-app` client (`secret` secret) and add `alice` (`admin` and `user` roles) and `bob` (`user` role) users, where all of these properties can be customized. | |||
| Use xref:security-openid-connect-dev-services.adoc[Dev Services for Keycloak] for integration testing against Keycloak. | |||
There was a problem hiding this comment.
It appears to me that this sentence does not have a message that this is a recommended way of testing. propose to revert
sberyozkin
reviewed
Nov 11, 2023
| @@ -1466,19 +1485,20 @@ Additionally, `OidcWiremockTestResource` set token issuer and audience to `https | |||
| [[integration-testing-keycloak-devservices]] | |||
| === Dev services for Keycloak | |||
|
|
|||
| Using xref:security-openid-connect-dev-services.adoc[Dev Services for Keycloak] is recommended for the integration testing against Keycloak. | |||
| `Dev Services for Keycloak` will launch and initialize a test container: it will create a `quarkus` realm, a `quarkus-app` client (`secret` secret) and add `alice` (`admin` and `user` roles) and `bob` (`user` role) users, where all of these properties can be customized. | |||
| Use xref:security-openid-connect-dev-services.adoc[Dev Services for Keycloak] for integration testing against Keycloak. | |||
There was a problem hiding this comment.
Suggested change
| Use xref:security-openid-connect-dev-services.adoc[Dev Services for Keycloak] for integration testing against Keycloak. | |
| Using xref:security-openid-connect-dev-services.adoc[Dev Services for Keycloak] is recommended for integration testing against Keycloak. |
sheilamjones
force-pushed
the
QDOCS-537-FINALQEPREP
branch
from
e571711 to
307383d
Compare
|
Thank you @sberyozkin. |
|
Following revised planning for 3.2.8 (and agreed with QE), this guide will not be published in Red Hat build of Quarkus for 3.2.8. Therefore, a backport to 3.2 is not needed and I removed the backport triage labels . The fixes applied in this PR will be fixed and published in Main only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses final edits, fixes Vale errors and warnings, and pre-QE checks in the OIDC authorization code flow mechanism for protecting web applications guide for 3.2