Allow to create named HTTP Security policies referenced in the application.properties path matching rules as CDI beans #37017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/docstyle
michalvavrik
force-pushed
the
feature/named-runtim-http-security-policies
branch
2 times, most recently
from
851aba1 to
b49eabc
Compare
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
sberyozkin
reviewed
Nov 11, 2023
sberyozkin
reviewed
Nov 11, 2023
sberyozkin
approved these changes
Nov 11, 2023
michalvavrik
force-pushed
the
feature/named-runtim-http-security-policies
branch
from
b49eabc to
c47168c
Compare
Failing Jobs - Building c47168c
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ |
|
I believe the gradle test failure is not related |
|
Thanks |
|
I dropped a new feature label for this PR as it is more like a bug fix I guess, please add it back if you prefer |
This was referenced Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that HTTP permissions and policies are configurable at runtime #36874, it makes sense to also allow users to configure named HTTP Security policies as CDI beans. Until now, it was only possible with build items (which this PR deprecates), but that only made sense for configuration properties were also build-time initialized.