Upgrade to Hibernate ORM 6.4, Hibernate Search 7.0, Hibernate Reactive 2.2

[yrodiere]

Creating as draft for now, because:

• We need an ORM 6.4.0.CR2/Final. => Done
• We still need a HR release and need to upgrade to that, because the current version doesn't work with ORM 6.4. => Done
• We may need a Hibernate Search 7.0.0.CR2/Final, but just for good measure as it seems to work as is. => Done

Fixes #37184
Fixes #36363
Fixes #35310
Fixes #33895
Fixes #32532
Fixes #33740

[quarkus-bot]

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm,hibernate-search)

[github-actions]

🙈 The PR is closed and the preview is expired.

[FroMage]

Excellent!

[FroMage]

The 6.4.0-SNAPSHOT branch (after CR1) wants one extra method in CustomMetadataBuilderContributor.HardcodedSuffixFunction

[yrodiere]

@beikov this change seems to introduce a backwards-incompatible API change for implementations of AbstractSqmSelfRenderingFunctionDescriptor: there is no default implementation for render(SqlAppender sqlAppender, List<? extends SqlAstNode> sqlAstArguments, ReturnableType<?> returnType, SqlAstTranslator<?> walker). Should we fix this in ORM?

[yrodiere]

Ah, all things SQM are considered incubating apparently:

https://docs.jboss.org/hibernate/orm/6.4/incubating/incubating.txt

org.hibernate.query.sqm.*

So... breaking changes are fair, please ignore me.

[yrodiere]

I added the upgrade to Hibernate ORM 6.4.0.Final, Hibernate Reactive 2.2.0.Final and Hibernate Search 7.0.0.CR2.

The tests should pass now, though I can't run them locally right now, so I marked as ready for review and will see what CI has to say about it (in particular about Hibernate Reactive).

[yrodiere]

Not sure what's going on, but CI skipped almost all jobs... I rebased and force-pushed, let's see how it goes.

[yrodiere]

I tried to fix what I noticed in the previous CI run, let's try again...

@marko-bekhta you might be interested by commits 2, 3 and 4. Turns out the tests you added for FormatMappers were more complex than I thought when I reviewed them xD

[quarkus-bot]

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[yrodiere]

Alright, the build finally passed! 🥳

Could I get an approval to get this merged, @gsmet?
Or @Sanne, but I think he's busy these days.

[gsmet]

We will need a note in the migration guide about:

Rename extension quarkus-hibernate-search-orm-coordination-outbox-polling to quarkus-hibernate-search-orm-outbox-polling

And if it's an extension that can be consumed by users, we should:

• keep it defined in the BOM for a while
• have redirections in place in the relocations/ module. They should be short given only the artifact changes.

This can be done once the PR is merged, I will merge it.

[gsmet]

It goes without saying but we will need a Final before 3.7.0 is out (but I'm sure you already have that in mind).

[gsmet]

Ah, I wanted to post an Approval review, and apparently clicked on the wrong checkbox.

As said, what I wrote above is not blocking, will merge!

[gsmet]

Thanks everyone, nice to have the latest ORM in Quarkus!

[yrodiere]

We will need a note in the migration guide about:

I added relevant notes for both ORM and Search to https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.7

And if it's an extension that can be consumed by users, we should:

keep it defined in the BOM for a while
have redirections in place in the relocations/ module. They should be short given only the artifact changes.

I kept it in the BOM. Will submit a PR for relocations.

[FroMage]

Great news!