-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vale error in grpc, oidc, and vertx areas #36960
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
@rolfedh: LGTM. No comments from my side. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bc2df2a
to
be3e534
Compare
be3e534
to
224f10f
Compare
This comment has been minimized.
This comment has been minimized.
Not needed for 3.2. Closing. Thanks. |
Reopening. For |
This comment has been minimized.
This comment has been minimized.
224f10f
to
bee369a
Compare
This comment has been minimized.
This comment has been minimized.
@sberyozkin I think this one can be merged into main. |
bee369a
to
a47c5e1
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rolfedh, All LGTM. Good catches on all these. Just had one very minor edit.
Kind regards,
Sheila
extensions/grpc/runtime/src/main/java/io/quarkus/grpc/runtime/config/SslServerConfig.java
Show resolved
Hide resolved
Failing Jobs - Building 49904b9
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment
! Skipped: extensions/keycloak-admin-client-reactive/deployment extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment and 52 more 📦 extensions/resteasy-reactive/rest-client-reactive/deployment✖
⚙️ Maven Tests - JDK 17 #- Failing: integration-tests/maven
📦 integration-tests/maven✖
✖
|
Doc changes only, so test failures are not related |
Purpose: Replace "key store", which generates a Vale error, with "keystore".
@sberyozkin This is a quality update for
main
.