Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vale error in grpc, oidc, and vertx areas #36960

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Nov 8, 2023

Purpose: Replace "key store", which generates a Vale error, with "keystore".
@sberyozkin This is a quality update for main.

Copy link

quarkus-bot bot commented Nov 8, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@rolfedh rolfedh changed the title fix key store Fix "key store" in security-oidc-configuration-properties-reference.adoc Nov 8, 2023
@rolfedh rolfedh requested a review from sberyozkin November 8, 2023 19:18
@rolfedh rolfedh changed the title Fix "key store" in security-oidc-configuration-properties-reference.adoc Fix vale error in grpc, oidc, and vertx areas Nov 8, 2023
@sheilamjones sheilamjones self-requested a review November 8, 2023 19:30
@sheilamjones
Copy link
Contributor

@rolfedh: LGTM. No comments from my side.

This comment has been minimized.

@rolfedh rolfedh marked this pull request as draft November 9, 2023 17:46

This comment has been minimized.

@rolfedh rolfedh marked this pull request as ready for review November 13, 2023 16:14
@rolfedh rolfedh marked this pull request as draft November 13, 2023 17:06
@rolfedh rolfedh marked this pull request as ready for review November 15, 2023 19:16
@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 15, 2023

Because this PR wouldn't backport to 3.2 cleanly, I cherry picked it to 3.2 in #37118 instead.
Because this PR might not backport to 3.5 cleanly, I cherry picked it to 3.5 in #37119 instead.

This comment has been minimized.

@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 16, 2023

Not needed for 3.2. Closing. Thanks.

@rolfedh rolfedh closed this Nov 16, 2023
@quarkus-bot quarkus-bot bot added triage/invalid This doesn't seem right and removed triage/backport-3.2 triage/backport? labels Nov 16, 2023
@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 20, 2023

Reopening. For main only.

@rolfedh rolfedh reopened this Nov 20, 2023
@quarkus-bot quarkus-bot bot removed the triage/invalid This doesn't seem right label Nov 20, 2023

This comment has been minimized.

This comment has been minimized.

@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 27, 2023

@sberyozkin I think this one can be merged into main.

This comment has been minimized.

Copy link
Contributor

@sheilamjones sheilamjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rolfedh, All LGTM. Good catches on all these. Just had one very minor edit.
Kind regards,
Sheila

@rolfedh rolfedh marked this pull request as draft January 8, 2024 13:14
@rolfedh rolfedh marked this pull request as ready for review January 10, 2024 16:45
Copy link

quarkus-bot bot commented Jan 10, 2024

Failing Jobs - Building 49904b9

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 🔍
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs 🔍
✔️ JVM Tests - JDK 21 🔍
Maven Tests - JDK 17 Build Failures Logs Raw logs 🔍
✔️ Maven Tests - JDK 17 Windows 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: extensions/keycloak-admin-client-reactive/deployment extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment and 52 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

io.quarkus.rest.client.reactive.StreamJsonTest.shouldReadUpToThreeTicks line 129 - More details - Source on GitHub

java.lang.AssertionError: Expected 3 items.  Only 1 items have been received.
	at io.smallrye.mutiny.helpers.test.AssertSubscriber.awaitItemEvents(AssertSubscriber.java:676)
	at io.smallrye.mutiny.helpers.test.AssertSubscriber.awaitItems(AssertSubscriber.java:440)
	at io.quarkus.rest.client.reactive.StreamJsonTest.shouldReadUpToThreeTicks(StreamJsonTest.java:129)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:500)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:414)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

⚙️ Maven Tests - JDK 17 #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 967 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "d6c83efd-66d0-4438-af68-02f14438b059" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 967 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "d6c83efd-66d0-4438-af68-02f14438b059" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@sberyozkin
Copy link
Member

Doc changes only, so test failures are not related

@sberyozkin sberyozkin merged commit d672c6d into quarkusio:main Jan 15, 2024
62 of 65 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants