Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wildfly-common version to 1.7.0.Final #36944

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Nov 8, 2023

Closes #36686

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Nov 8, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Nov 8, 2023

@zakkak Could you please kick off a mandrel CI build with this as well? I'd like to see the change in results for native-image tests based on Mandrel for JDK 22. Thanks!

@zakkak
Copy link
Contributor Author

zakkak commented Nov 8, 2023

@jerboaa
Copy link
Contributor

jerboaa commented Nov 8, 2023

Good point.

Please see https://github.com/graalvm/mandrel/actions/runs/6798911351

Heh, 22+22 doesn't work. Could you try with 22+21 and/or with a local patch for latest JDK 22 support? Failing that, a local test is sufficient for me too :)

@zakkak
Copy link
Contributor Author

zakkak commented Nov 8, 2023

Unfortunately there is no way to instruct our CI to use a specific JDK 22 release so I will run with GraalVM CE instead of Mandrel. Running locally is also an option but will take too long to run all the tests.

https://github.com/graalvm/mandrel/actions/runs/6799010528

@jerboaa
Copy link
Contributor

jerboaa commented Nov 8, 2023

Unfortunately there is no way to instruct our CI to use a specific JDK 22 release so I will run with GraalVM CE instead of Mandrel. Running locally is also an option but will take too long to run all the tests.

https://github.com/graalvm/mandrel/actions/runs/6799010528

Thanks! GraalVM CE is fine.

Copy link

quarkus-bot bot commented Nov 8, 2023

Failing Jobs - Building 4000072

Status Name Step Failures Logs Raw logs Build scan
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 21
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.CustomManifestArgumentsTest.shouldContainsSpecificManifestProperty line 37 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual not to be null

@jerboaa
Copy link
Contributor

jerboaa commented Nov 8, 2023

Unfortunately there is no way to instruct our CI to use a specific JDK 22 release so I will run with GraalVM CE instead of Mandrel. Running locally is also an option but will take too long to run all the tests.

https://github.com/graalvm/mandrel/actions/runs/6799010528

Are you sure this was building the correct quarkus version? Looks to me it built revision ff9047485f3169931f2def3e609f5d2cc14a2b76. Shouldn't it build 4000072d054317495d514f165d94c82b32df9983? Either way, the test failures are still the same in the above test run.

@zakkak
Copy link
Contributor Author

zakkak commented Nov 8, 2023

@jerboaa good catch, I was working on another issue and used the wrong branch...

I hope third time's the charm
https://github.com/graalvm/mandrel/actions/runs/6803742613

Update: GraalVM CE 24.0.0-SNAPSHOT runs look good (as in this PR fixes #36686

@zakkak zakkak requested review from dmlloyd and geoand November 9, 2023 08:44
@geoand
Copy link
Contributor

geoand commented Nov 9, 2023

I have no idea what this library does, I'll leave reviewing to someone else

@gsmet gsmet merged commit 7f50299 into quarkusio:main Nov 9, 2023
48 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Nov 9, 2023
@zakkak zakkak deleted the 2023-11-08-fix-36686 branch November 9, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus native tests fail with latest GraalVM CE for JDK 22, 24.0.0-dev builds due to wildfly substitution
4 participants