Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis vector fields and arguments #36939

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Redis vector fields and arguments #36939

merged 2 commits into from
Nov 8, 2023

Conversation

jmartisk
Copy link
Contributor

@jmartisk jmartisk commented Nov 8, 2023

  • Support byte array arguments in the data source api
  • Support for supplying vector field parameters when creating vector fields with FT_CREATE with the data source api

@jmartisk jmartisk requested a review from cescoffier November 8, 2023 08:44
@jmartisk jmartisk force-pushed the redis-vector-arguments branch from a82dacc to 53c799c Compare November 8, 2023 08:44
@jmartisk jmartisk mentioned this pull request Nov 8, 2023
Closed
@jmartisk
Copy link
Contributor Author

jmartisk commented Nov 8, 2023 •
edited
Loading

@cescoffier It's a bit awkward because I'm adding arguments specific to vector fields into FieldOptions. Perhaps we could split out a new VectorFieldOptions class, rename the current FieldOptions to TextFieldOptions and extract a FieldOptions interface or something? I'm rather asking beforehand because this is a breaking change...

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 8, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

cescoffier
cescoffier approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cescoffier cescoffier merged commit 3d7daa8 into quarkusio:main Nov 8, 2023
30 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Nov 8, 2023
@jmartisk jmartisk deleted the redis-vector-arguments branch November 8, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/redis
Projects
None yet
Milestone
3.6.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@jmartisk @cescoffier