Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar error in OIDC and Bootstrap JavaDocs #36927

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Nov 7, 2023

@sberyozkin This is a quality update for main.
Do you approve backporting it to 3.2 as well?

Copy link

quarkus-bot bot commented Nov 7, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@rolfedh rolfedh requested a review from sberyozkin November 7, 2023 18:16
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/oidc labels Nov 7, 2023
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Rolfe

@sberyozkin sberyozkin changed the title Fix grammar error: Replace "different to" with "different from". Fix grammar error in OIDC and Bootstrap JavaDocs Nov 7, 2023
@sberyozkin
Copy link
Member

@rolfedh I'e just updated the PR title a bit to make the bot happy, please update it further if you'd like, also proposed a backport to 3.2, thanks

This comment has been minimized.

Copy link

quarkus-bot bot commented Nov 8, 2023

Failing Jobs - Building d89abdb

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 21 Build ⚠️ Check → Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/redis-client/runtime 
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/micrometer-registry-prometheus/runtime extensions/micrometer/deployment and 44 more

📦 extensions/redis-client/runtime

io.quarkus.redis.datasource.PubSubCommandsTest.subscribeToMultiplePatternsWithMulti line 287 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.redis.datasource.PubSubCommandsTest that uses java.util.List was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

Copy link
Contributor

@michelle-purcell michelle-purcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too @rolfedh. Thanks.

@sberyozkin
Copy link
Member

Test failures are not related, merging now

@sberyozkin sberyozkin merged commit 80fbefb into quarkusio:main Nov 8, 2023
48 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Nov 8, 2023
@gsmet gsmet modified the milestones: 3.6 - main, 3.5.2 Nov 13, 2023
@aloubyansky aloubyansky modified the milestones: 3.5.2, 3.2.9.Final Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/oidc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants