-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grammar error in OIDC and Bootstrap JavaDocs #36927
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Rolfe
@rolfedh I'e just updated the PR title a bit to make the bot happy, please update it further if you'd like, also proposed a backport to 3.2, thanks |
This comment has been minimized.
This comment has been minimized.
182e5a5
to
0072d46
Compare
Co-Authored-By: Rolfe Dlugy-Hegwer <[email protected]>
0072d46
to
d89abdb
Compare
Failing Jobs - Building d89abdb
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/redis-client/runtime
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/micrometer-registry-prometheus/runtime extensions/micrometer/deployment and 44 more 📦 extensions/redis-client/runtime✖
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too @rolfedh. Thanks.
Test failures are not related, merging now |
@sberyozkin This is a quality update for
main
.Do you approve backporting it to
3.2
as well?