-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keycloak DevService: Improve error messages and documentation #36883
Conversation
5aa55a7
to
88fa7b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This comment has been minimized.
This comment has been minimized.
@Felk Can you please follow up with a formatting fix and squash the commits afterwards ? |
88fa7b1
to
77fcb1f
Compare
Sure! I amended the formatting fix |
This comment has been minimized.
This comment has been minimized.
77fcb1f
to
672348a
Compare
@Felk I did another formatting update and also removed the description of the problem which was a copy and paste of this PR's description from the commit message, thanks |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Thanks for taking the time to handle that. |
We used to experience a lot of flakiness due to the keycloak devservice starting, but doing so with errors and therefore causing all tests that were running with keycloak to emit 'IllegalArgument accessToken cannot be null'. The start-up errors were a bit cryptic and unspecific and looked like this:
It took us some time to realize that
Admin token can not be acquired: null
actually meant 'Acquiring the Admin token timed out' and that 'null' was the TimeoutException's message. Thankfully the propertyquarkus.oidc.devui.web-client-timeout
exists to increase this timeout, though it is somewhat oddly named ("devui"? Should these properties be split into two?).I tried to improve the situation by making errors actually print the exception and stacktrace, and by improving the user feedback a bit.