Adds Pattern support to Kafka Streams Topology Dev UI #36871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Topologies with a pattern source appear in the graph. |
gsmet
reviewed
Nov 7, 2023
There was a problem hiding this comment.
Thanks! I added a small question.
Probably something for @ozangunalp and @phillip-kruger to review.
Comment on lines
-83
to
-87
| for (int i = 0; i < subGraphs.size(); i++) { | ||
| res.add(" subgraph cluster" + i + " {"); | ||
| res.add(" label=\"Sub-Topology: " + i + "\"; color=\"#C8C879\"; bgcolor=\"#FFFFDE\";"); | ||
| res.add(" }"); | ||
| } |
|
It was a forgotten trace of the initial loop, obsolete and useless after it was rewritten as a stream (previous lines in source code). This part is fully covered by the unit test and result didn't change after this code cleaning.
|
This comment has been minimized.
This comment has been minimized.
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
phillip-kruger
approved these changes
Nov 8, 2023
|
Merging. @ozangunalp please let us know if there is any concerns (and we can roll forward) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #29411