Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include removed dependencies in the ApplicationModel #36859

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Include removed dependencies in the ApplicationModel #36859

merged 1 commit into from
Nov 7, 2023

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Nov 3, 2023 •
edited by aloubyansky
Loading

DependencyFlags.REMOVED was added to represent dependencies removed from the classloaders.
And ApplicationModel now allows to get dependencies with a specific flag.

@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven labels Nov 3, 2023
@aloubyansky aloubyansky force-pushed the expose-removed-dependencies branch from aa5a0bd to e587bf1 Compare November 6, 2023 15:25
@aloubyansky aloubyansky marked this pull request as ready for review November 6, 2023 15:30
@aloubyansky aloubyansky changed the title Include removed dependencies in the ApplicationModel with Include removed dependencies in the ApplicationModel Nov 6, 2023
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 6, 2023

Failing Jobs - Building e587bf1

Status Name Step Failures Logs Raw logs Build scan
✖ JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 21

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: independent-projects/tools/analytics-common integration-tests/container-image/maven-invoker-way 
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/maven and 221 more

📦 independent-projects/tools/analytics-common

✖ io.quarkus.analytics.AnalyticsServicePromptTest.testConsoleQuestion_promptTimeout line 75 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

✖ io.quarkus.analytics.ConfigServiceTest.userAcceptance_no line 206 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: Local config file must be present ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

✖ io.quarkus.analytics.ConfigServiceTest.userAcceptance_yes line 190 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

📦 integration-tests/container-image/maven-invoker-way

✖ Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.6.0:run (integration-tests) on project quarkus-integration-test-container-image-invoker: 1 build failed. See console output above for details.

ia3andy
ia3andy commented Nov 7, 2023
View reviewed changes
Copy link
Contributor Author

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Maven and Gradle thanks

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 7, 2023

@aloubyansky I can't approve as I created the PR :-)

@aloubyansky
Copy link
Member

Well, I can't approve it either :D

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 7, 2023

@aloubyansky I approve it (you can approve it)

@aloubyansky
Copy link
Member

No, I really can't :) Either I need to open a new PR or somebody else should approve.

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 7, 2023

Lol I've asked @maxandersen to approve 😅

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 7, 2023

deadlock

@ia3andy ia3andy mentioned this pull request Nov 7, 2023
Closed
aloubyansky
aloubyansky approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, i can approve it, sorry.

@aloubyansky aloubyansky merged commit 7856920 into quarkusio:main Nov 7, 2023
62 of 65 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven
Projects
None yet
Milestone
3.6.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@ia3andy @aloubyansky