Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quarkus-scheduler startMode documentation #36769

Closed

Conversation

nderwin
Copy link
Contributor

@nderwin nderwin commented Oct 29, 2023

Signed-off-by:Nathan Erwin [email protected]

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 29, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@nderwin nderwin changed the title update quarkus-scheduler startMode documentation Update quarkus-scheduler startMode documentation Oct 29, 2023
@nderwin nderwin force-pushed the bugfix/update-scheduler-javadocs branch from 5d22480 to df8b7e0 Compare October 30, 2023 17:02
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/platform Issues related to definition and interaction with Quarkus Platform labels Oct 31, 2023
@nderwin nderwin force-pushed the bugfix/update-scheduler-javadocs branch from 9483a73 to bac60e9 Compare October 31, 2023 11:01
* removed the paragraph tags from the enum javadoc because they don't translate well into asciidoc and subsequently HTML tooltips
* potential fix for quarkusio#36401

Signed-off-by:Nathan Erwin <[email protected]>
@nderwin nderwin force-pushed the bugfix/update-scheduler-javadocs branch from bac60e9 to ecbd093 Compare October 31, 2023 11:05
@github-actions
Copy link

🎊 PR Preview e6423a4 has been successfully built and deployed to https://quarkus-pr-main-36769-preview.surge.sh/version/main/guides/

@quarkus-bot

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I wonder if we should strip them automatically when transforming this to Asciidoc? That would avoid further breakages?

@nderwin
Copy link
Contributor Author

nderwin commented Nov 7, 2023

LGTM but I wonder if we should strip them automatically when transforming this to Asciidoc? That would avoid further breakages?

I pondered that, but there was some discussion about if this code only produces Asciidoc for the config settings, or if it's used for other things where we'd want to leave the paragraph tags in there.

Copy link

quarkus-bot bot commented Nov 13, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@michalvavrik
Copy link
Member

LGTM but I wonder if we should strip them automatically when transforming this to Asciidoc? That would avoid further breakages?

+1, there is zero chance we can control this manually, sooner or later this will happen again

I pondered that, but there was some discussion about if this code only produces Asciidoc for the config settings, or if it's used for other things where we'd want to leave the paragraph tags in there.

I remember I had a way to do not add tooltip when it is not Asciidoc, therefore there should be also a way to only strip it when required. Unfortunately after that time I don't remember details. Let me try early next week rather than merging this fix. Thank you

@michalvavrik
Copy link
Member

@nderwin I had a look and it's safe to strip <p> whenever is io.quarkus.annotation.processor.Constants#TOOLTIP used because then you know macro will be applied or description content won't be visible. Thank you for analysis and information. I think fixing it can be as simple as #37202. Sure, we can make it more robust, but IMHO it is not necessary (it must only cover how we write docs, not general case).

@nderwin nderwin closed this Nov 27, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/platform Issues related to definition and interaction with Quarkus Platform area/scheduler triage/invalid This doesn't seem right
Projects
Development

Successfully merging this pull request may close these issues.

3 participants