-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quarkus-scheduler startMode documentation #36769
Update quarkus-scheduler startMode documentation #36769
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
5d22480
to
df8b7e0
Compare
9483a73
to
bac60e9
Compare
* removed the paragraph tags from the enum javadoc because they don't translate well into asciidoc and subsequently HTML tooltips * potential fix for quarkusio#36401 Signed-off-by:Nathan Erwin <[email protected]>
bac60e9
to
ecbd093
Compare
🎊 PR Preview e6423a4 has been successfully built and deployed to https://quarkus-pr-main-36769-preview.surge.sh/version/main/guides/ |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I wonder if we should strip them automatically when transforming this to Asciidoc? That would avoid further breakages?
I pondered that, but there was some discussion about if this code only produces Asciidoc for the config settings, or if it's used for other things where we'd want to leave the paragraph tags in there. |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
+1, there is zero chance we can control this manually, sooner or later this will happen again
I remember I had a way to do not add tooltip when it is not Asciidoc, therefore there should be also a way to only strip it when required. Unfortunately after that time I don't remember details. Let me try early next week rather than merging this fix. Thank you |
@nderwin I had a look and it's safe to strip |
Signed-off-by:Nathan Erwin [email protected]