Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenSearch container test configuration #36720

Merged

Conversation

marko-bekhta
Copy link
Contributor

  • Limit OpenSearch memory usage
  • Disable disk-based shard allocation thresholds

- Limit OpenSearch memory usage
- Disable disk-based shard allocation thresholds
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 26, 2023

/cc @gsmet (elasticsearch,hibernate-search), @loicmathieu (elasticsearch), @yrodiere (elasticsearch,hibernate-search)

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yrodiere
Copy link
Member

We could technically backport the docker-maven-plugin changes to branches earlier than 3.5, but... not sure it's worth it?

The part about dev services can only be backported to 3.5 and 3.4, as OpenSearch dev services were introduced in 3.4.

@gsmet
Copy link
Member

gsmet commented Oct 26, 2023

Let's backport only to 3.5.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 26, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit cf9e5ef into quarkusio:main Oct 26, 2023
22 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 26, 2023
@gsmet gsmet modified the milestones: 3.6 - main, 3.5.1 Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants