-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore bridge methods and improve error message in @Embeddable annotation checks #36713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
And thanks for taking the time to improve the error message, I'm sure users will appreciate.
Should we backport this to 3.2.x? |
I don't remember if I backported this check to 3.2. IIRC I was a bit skeptical. |
Looks like you didn't, it's only in 3.4.0: https://github.com/quarkusio/quarkus/releases?q=35822&expanded=true |
Let's backport it for the next 3.5 anyway. |
Failing Jobs - Building 83cd68b
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/hibernate-search-orm-elasticsearch-tenancy integration-tests/hibernate-search-orm-opensearch
📦 integration-tests/hibernate-search-orm-elasticsearch-tenancy✖ 📦 integration-tests/hibernate-search-orm-opensearch✖
|
The test failure seems caused by I/O errors when contacting docker.io. Merging, thanks! |
Fixes #36421
Addresses #36421 (comment)
Best reviewed commit by commit.