Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore bridge methods and improve error message in @Embeddable annotation checks #36713

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

yrodiere
Copy link
Member

Fixes #36421
Addresses #36421 (comment)

Best reviewed commit by commit.

@yrodiere yrodiere requested a review from gsmet October 26, 2023 11:08
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Oct 26, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 26, 2023

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm)

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 26, 2023
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

And thanks for taking the time to improve the error message, I'm sure users will appreciate.

@gastaldi
Copy link
Contributor

Should we backport this to 3.2.x?

@gsmet
Copy link
Member

gsmet commented Oct 26, 2023

I don't remember if I backported this check to 3.2. IIRC I was a bit skeptical.

@yrodiere
Copy link
Member Author

I don't remember if I backported this check to 3.2. IIRC I was a bit skeptical.

Looks like you didn't, it's only in 3.4.0: https://github.com/quarkusio/quarkus/releases?q=35822&expanded=true

@gsmet
Copy link
Member

gsmet commented Oct 26, 2023

Let's backport it for the next 3.5 anyway.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 26, 2023

Failing Jobs - Building 83cd68b

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 21

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/hibernate-search-orm-elasticsearch-tenancy integration-tests/hibernate-search-orm-opensearch 

📦 integration-tests/hibernate-search-orm-elasticsearch-tenancy

Failed to execute goal io.fabric8:docker-maven-plugin:0.43.4:start (docker-start) on project quarkus-integration-test-hibernate-search-orm-elasticsearch-tenancy: I/O Error

📦 integration-tests/hibernate-search-orm-opensearch

io.quarkus.it.hibernate.search.orm.opensearch.devservices.HibernateSearchOpenSearchDevServicesConfiguredExplicitlyTest.testDevServicesProperties - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.elasticsearch.restclient.common.deployment.DevServicesElasticsearchProcessor#startElasticsearchDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/opensearchproject/opensearch:2.8.0

@yrodiere
Copy link
Member Author

The test failure seems caused by I/O errors when contacting docker.io. Merging, thanks!

@yrodiere yrodiere merged commit 11cf607 into quarkusio:main Oct 26, 2023
39 of 40 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 26, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 26, 2023
@gsmet gsmet modified the milestones: 3.6 - main, 3.5.1 Oct 26, 2023
@yrodiere yrodiere deleted the i36421 branch January 29, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants