Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gitpod configuration with Java 17 #36665

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Update Gitpod configuration with Java 17 #36665

merged 1 commit into from
Oct 24, 2023

Conversation

jeanphi-baconnais
Copy link
Contributor

@jeanphi-baconnais jeanphi-baconnais commented Oct 24, 2023 •
edited by gsmet
Loading

Fix #36654

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 24, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@jeanphi-baconnais jeanphi-baconnais changed the title ⬆️ Update Gitpod configuration with Java 17 Update Gitpod configuration with Java 17 Oct 24, 2023
gsmet
gsmet approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, I rebased to avoid the merge commit.

Will merge right away given no CI is needed.

@gsmet gsmet merged commit 693bb15 into quarkusio:main Oct 24, 2023
2 of 5 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Oct 24, 2023
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
3.6.0.CR1
Development

Successfully merging this pull request may close these issues.

Migrate Java version in Gitpod configuration to Java 17
2 participants
@jeanphi-baconnais @gsmet