-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 32595 - Kafka Streams Dev UI migration to v2 #36650
Conversation
Thanks a lot, I pinged @phillip-kruger so that he can have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think we can merge once the change is made
import { unsafeHTML } from 'lit/directives/unsafe-html.js'; | ||
import { JsonRpc } from 'jsonrpc'; | ||
|
||
import { Graphviz } from "https://cdn.jsdelivr.net/npm/@hpcc-js/wasm/dist/graphviz.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you can use import { Graphviz } from "@hpcc-js/wasm/graphviz";
and add this to deployment/pom.xml:
<dependency>
<groupId>org.mvnpm.at.hpcc-js</groupId>
<artifactId>wasm</artifactId>
<version>2.14.1</version>
<scope>runtime</scope>
</dependency>
You can also add above to build parent pom dependency management and reference in the extension pom without the version
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has been minimized.
This comment has been minimized.
@dcotfr Thanks for this ! Please rebase and squash your PR, and then on green CI we can merge |
This comment has been minimized.
This comment has been minimized.
@dcotfr seems like the wasm js dependency pulls in a lot of other dependencies with ranges. To make our build faster we lock these in the build-parent. I'll send you (a bit later) what needs to be added to the build parent. |
Proposal of rewriting of Kafka Streams Dev UI for v2.
Replaces Mermaid usage by a wasm version of Graphviz (seems lighter and with less dependencies).
Still generates a mermaid graph definition (for backward compatibility) and adds a new digraph definition for Graphviz.
Warning : contains a direct link to https://cdn.jsdelivr.net/npm/@hpcc-js/wasm/dist/graphviz.js in qwc-kafka-streams-topology.js, because I don't know how to include this dependency with in a more cleaner / secured way.
fixes #32595